Deprecated clean_url() in favor of esc_url(), and deprecated sanitize_url() in favor of esc_url_raw().
Updates from May, 2009 Toggle Comment Threads | Keyboard Shortcuts
-
Mark Jaquith
-
Mark Jaquith
Deprecated
wp_specialchars()in favor ofesc_html()(also:esc_html__()andesc_html_e()). Usingwp_specialchars()with more than one param works for backwards compat. Also,esc_html()(orwp_specialchars()with one param) escapes quotes, just likeesc_attr(). This buys security for plugin authors who were mistakenly using a one-paramwp_specialchars()call in an HTML attribute. See this wp-hackers message for more detail. -
Peter Westwood
Trying to keep the commit candidates under control. Every time I look up the list gets bigger.
-
Denis de Bernardy
Yeah, I did some cleaning up and testing.
-
Denis de Bernardy
It would help if they got committed or rejected with feedback faster, btw.
trac wouldn’t be so overcluttered with tickets if commit candidates got looked into on the spot. and contributors would have more incentive to maintain their patches. as things are, a valid ticket can easily be ignored for a year from lack of traction, and that is quite discouraging for contributors.
some oss projects (pgsql) have a bug-to-feedback process of under 48 hours. that helps *a lot* to get the community involved. especially, as is the case of pgsql, when it usually means bug-to-fix.
-
Peter Westwood
We do try to respond as fast as possible. But responding is not a short task and good quality patch review takes time.
You have to make sure that the bug is being fixed in the correct way.
Often lack of detail in the ticket will make this take longer
-
-
-
Mark Jaquith
Standardizing and shortening the WP security escaping functions.
attribute_escape()is nowesc_attr()Additionally, you can do attribute escaping and translation in one go. Just add the translation function to the end. Like so:
esc_attr__()— translate and return, attribute-escaped.esc_attr_e()— translate and echo, attribute-escaped.
Will be following up with
esc_html(with__()and_e()variants),esc_url(), maybe some more. Will be nice, short, predictable, and allow you do translate/escape in one go without a lot of nested parenthesis.-
Viper007Bond
An
esc_js()or whatnot might be useful to (i.e. an improvedjs_escape()(see #7648).-
Mark Jaquith
Yes, I meant to include that in the list of “coming soon” ones. Though
js_escape()would continue to work, as wouldattribute_escape()andwp_specialchars().Improvements to
esc_js()néejs_escape()are a separate issue — I’ll take a look at that ticket.
-
-
Leandro Vieira Pinho
Why not escape_attr than esc_attr?. Write escape is more intuitive than esc.
Andrew Ozz
Going through some of the accessibility improvements. 2.7 was tested with JAWS but there were some changes in the UI since then. Does anybody use JAWS or another screen reader, or know somebody that uses it? Feedback is welcome.
-
Ryan
I do someone who uses Jaws. I’ll send a link to this page to them in case they are keen to help out.
I’ve sent him an email. Hopefully he’ll be keen to help out. -
slger
Is there a list of accessibility items to test? I’ll work on them.
My biggest problem: can’t get rid of archieves. Also cannot see theme well enough to know if it looks ok. What’s the most accessible theme?
-
Ryan
This ticket has some discussion on hidden labels.
-
Lynne
FWIW, I know of a couple of folk who use assistive devices and who cannot use 2.7. As far as I know, they are still on 2.6.5. JAWS is only one of a number of assistive devices and even with JAWS users, proficiency varies. Accessibility with JAWS depends on the users level of experience and also on which browser they are using. EYES has the same issues. Headwands, voice recognition, etc also rely on the site being accessible and, again, these are things most of us can’t test.
Having said that, there are a number of people, including people with disabilities, who are keen to see WordPress become fully accessible. Some just walked away after concerns about 2.7 got fobbed off with the comment that it underwent usability testing and was therefore ok. I pretty much shut up about accessibility at that time too, and although I develop sites for others on 2.7/2.7.1, my own site remains on 2.6.5 because of accessibility issues.
Don’t try to go it alone guys – great coders are not expected to be experts in web app accessibility. If you put accessibility improvements on the roadmap for 2.9 and would consider opening a wp-accessibility mailing list for those in the accessibility field to discuss issues and fixes in, I can get a call out to the Guild of Accessible Web Designers and others I network with and get people working on this.
Just a thought.
-
Glenda Watson Hyatt
Great point, Lynne! Involve people with disabilities who use various assistive technology in to development and testing.
-
Jane Wells
Lynne, who commented that 2.7 underwent usability testing and was therefore okay? Not any of the core team, I’m sure, as we did have someone from an accessibility company do a review for us during the 2.7 dev cycle, and we fixed as many of the things as we could. Usability and accessibility are not the same, and we all recognize that. There’s definitely room for improvement, but we absolutely are paying attention.
-
Lynne
I put in a request through wp-hackers a few weeks back, asking if we could have a wp-accessibility mailing list set up please. There are enough people interested in contributing to development and testing for accessibility that a dedicated mailing list would, IMO, be very worthwhile.
Has there been any decision made on this yet? Accessibility discussion just gets lost in the busy wp-hackers list & that list is not perceived as the most inviting for those whose primary interest is in accessibility issues.
-
Barry
This should be done in the next week or so.
-
-
-
Lorelle VanFossen
Don’t forget to include Glenda Watson Hyatt of http://www.doitmyselfblog.com/ as she is an accessibility expert, WordPress fan, and living tester of these things. She has top connections, too, to help. @glendaWH on Twitter.
Lloyd Budd 4:48 pm on May 21, 2009 Permalink |
http://codex.wordpress.org/Data_Validation will need an update.